[PATCH] D18608: note for top-level consts in function decls tidy

Richard via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 30 14:33:23 PDT 2016


LegalizeAdulthood added inline comments.

================
Comment at: docs/ReleaseNotes.rst:153-154
@@ -152,2 +152,4 @@
 
+  * `readability-avoid-const-params-in-decls
+    <http://llvm.org/releases/3.8.0/tools/clang/tools/extra/docs/clang-tidy/checks/readability-avoid-const-params-in-decls.html>`_
   * `readability-identifier-naming
----------------
fowles wrote:
> LegalizeAdulthood wrote:
> > Was this added in 3.8 or is it being added in 3.9?
> > 
> > That URL gives me 404 not found.
> > 
> > If it is new to 3.9, it should be farther up in the file.
> I don't know.  It was committed yesterday.
Hrm.  I see the page describing it here:
http://clang.llvm.org/extra/clang-tidy/checks/readability-avoid-const-params-in-decls.html
but I think those docs are continuously rebuilt from trunk.

The release specific URL you added does not work and if you look in the base directory for that URL:
http://llvm.org/releases/3.8.0/tools/clang/tools/extra/docs/clang-tidy/checks/
you will not find a file for readability-avoid-const-params-in-decls

I suspect it means that the documentation was added since the 3.8 release and therefore the check isn't actually available in the 3.8 release either.  Yep, looking at the github mirror for branch release_38, this check isn't present.  See the [[ https://github.com/llvm-mirror/clang-tools-extra/tree/release_38/clang-tidy/readability | mirror on github ]] to verify this.

Therefore, I conclude that the check should be listed in the what's new for 3.9 section and not what was added between 3.7 and 3.8.


http://reviews.llvm.org/D18608





More information about the cfe-commits mailing list