[PATCH] D17412: PR19957: [OpenCL] incorrectly accepts implicit address space conversion with ternary operator
Anastasia Stulova via cfe-commits
cfe-commits at lists.llvm.org
Wed Mar 30 09:42:57 PDT 2016
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM, please correct two small issues commented here!
================
Comment at: lib/Sema/SemaExpr.cpp:169
@@ -168,4 +168,3 @@
break;
-
bool Warn = !D->getAttr<AvailabilityAttr>()->isInherited();
// Objective-C method declarations in categories are not modelled as
----------------
Why removing line here?
================
Comment at: lib/Sema/SemaExpr.cpp:6192
@@ -6181,2 +6191,3 @@
+ // Cases 1c, 2a, 2b, and 2c.
if (CompositeTy.isNull()) {
----------------
add OpenCL
http://reviews.llvm.org/D17412
More information about the cfe-commits
mailing list