[PATCH] D18582: [Clang-tidy] Update release notes with list of checks added since 3.8

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 30 05:27:39 PDT 2016


alexfh added a comment.

A few more nits.


================
Comment at: docs/ReleaseNotes.rst:68
@@ +67,3 @@
+
+  This check flags calls to ``system()``, ``popen()``, and ``_popen()``, which
+  execute a command processor.
----------------
I'd remove "This check" at the start of all check descriptions.

================
Comment at: docs/ReleaseNotes.rst:85
@@ +84,3 @@
+  This check detects dangling references in value handlers like
+  `std::experimental::string_view`.
+
----------------
nit: Double backquotes should be used for inline code snippets.

================
Comment at: docs/ReleaseNotes.rst:112
@@ +111,3 @@
+
+  Optimize calls to std::string::find() and friends when the needle passed is a
+  single character string literal.
----------------
nit: Double backquotes should be used for inline code snippets.

================
Comment at: docs/ReleaseNotes.rst:117
@@ +116,3 @@
+
+  This check warns about range-based loop with loop variable of const ref type
+  where the type of the variable does not match the one returned by the
----------------
nit: "with a loop variable"

================
Comment at: docs/ReleaseNotes.rst:139
@@ +138,3 @@
+
+  Crash when ``clang-tidy`` runs on compile database with relative source files
+  paths.
----------------
nit: Should be :program:<backquote>clang-tidy<backquote>


Repository:
  rL LLVM

http://reviews.llvm.org/D18582





More information about the cfe-commits mailing list