[PATCH] D17142: SystemZ: Check required features when handling builtins

Ulrich Weigand via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 30 04:23:09 PDT 2016


uweigand added a comment.

I don't think we actually need the builtins-systemz-z13.c test, it only duplicates tests already done by builtins-systemz.c and builtins-systemz-vector.c.  (Note that those tests implicitly verify that there is no compiler error by checking the compiler exit code.)

Also, you should be able to combine the two -generic tests into a single one (the compiler doesn't abort at errors, so you can check for multiple errors with a single -verify run).  Maybe the combined test should be named builtins-systemz-error.c ?

LGTM with those changes.


http://reviews.llvm.org/D17142





More information about the cfe-commits mailing list