[PATCH] D18457: [clang-tidy] Add a new checker to detect missing comma in initializer list.
Etienne Bergeron via cfe-commits
cfe-commits at lists.llvm.org
Tue Mar 29 13:21:51 PDT 2016
etienneb added inline comments.
================
Comment at: clang-tidy/misc/SuspiciousMissingCommaCheck.cpp:42
@@ +41,3 @@
+ const auto *ConcatenatedLiteral = Result.Nodes.getNodeAs<Expr>("str");
+ if (InitializerList && ConcatenatedLiteral) {
+ // Skip small arrays as they often generate false-positive.
----------------
alexfh wrote:
> An early return would be better here.
moved to an assert.
It should never be false.
http://reviews.llvm.org/D18457
More information about the cfe-commits
mailing list