[PATCH] D17407: [Sema] PR25755 Fix crash when initializing out-of-order struct references

don hinton via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 28 17:30:05 PDT 2016


hintonda marked 7 inline comments as done.

================
Comment at: lib/Sema/SemaInit.cpp:1815-1816
@@ -1814,3 +1814,4 @@
   // worthwhile to skip over the rest of the initializer, though.
   RecordDecl *RD = DeclType->getAs<RecordType>()->getDecl();
   RecordDecl::field_iterator FieldEnd = RD->field_end();
+  RecordDecl::field_iterator FieldStart = Field;
----------------
Still need FieldSize -- see below.

================
Comment at: lib/Sema/SemaInit.cpp:1856
@@ -1843,3 +1855,3 @@
 
     if (Field == FieldEnd) {
       // We've run out of fields. We're done.
----------------
Couldn't find getNumFields(), counted them instead.


http://reviews.llvm.org/D17407





More information about the cfe-commits mailing list