[PATCH] D17002: [lanai] Add Lanai backend to clang driver
Chandler Carruth via cfe-commits
cfe-commits at lists.llvm.org
Mon Mar 28 12:54:26 PDT 2016
chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.
LGTM with the comments from David addressed and the comment below addressed.
================
Comment at: lib/Basic/Targets.cpp:6000-6001
@@ +5999,4 @@
+ break;
+ default:
+ llvm_unreachable("Unhandled target CPU");
+ }
----------------
Instead of a default, make this a covering switch? We get warnings that way if someone adds a CPU and doesn't add a case.
http://reviews.llvm.org/D17002
More information about the cfe-commits
mailing list