[PATCH] D18300: [clang-tidy] ProTypeMemberInitCheck - check that field decls do not have in-class initializer

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 28 08:08:57 PDT 2016


aaron.ballman added inline comments.

================
Comment at: test/clang-tidy/cppcoreguidelines-pro-type-member-init.cpp:94
@@ +93,3 @@
+  bool Bool{false};
+  // CHECK-FIXES: bool Bool{false};
+};
----------------
flx wrote:
> aaron.ballman wrote:
> > Why is this checking a fix? I thought that point was that this should not generate any diagnostic (and hence, no fix is required)?
> If I understood Alex correctly, CHECK-FIXES is needed to check for the absence of a change made by ClangTidy. But I agree it seems unlikely to have a change without a warning message which will trigger a test failure at any rate.
@alexfh, what are your thoughts on this? It seems like we should be able to test negative fixes, like with CHECK-NOT, except CHECK-FIXES-NOT or some such?


Repository:
  rL LLVM

http://reviews.llvm.org/D18300





More information about the cfe-commits mailing list