[PATCH] D18498: Auto-install Clang Visual Studio visualizers for VS2015 and up

[Alexander Riccio via cfe-commits]

ariccio added a comment.

Assuming everything builds correctly, LGTM.

Your CMake is better than mine, so I'm not sure if there're better ways to do this ;)


================
Comment at: utils/ClangVisualizers/CMakeLists.txt:2
@@ +1,3 @@
+# Do this by hand instead of using add_llvm_utilities(), which
+# tries to create a corresponding executable, which we don't want
+if (LLVM_ADD_NATIVE_VISUALIZERS_TO_SOLUTION)
----------------
Obsessive nit: Use a period after the "want", like `want.`

================
Comment at: utils/ClangVisualizers/clang.natvis:9
@@ -8,2 +8,3 @@
+For later versions of Visual Studio, no setup is required-->
 <AutoVisualizer xmlns="http://schemas.microsoft.com/vstudio/debugger/natvis/2010">
 
----------------
Is it just me, or is this a dead link?


http://reviews.llvm.org/D18498