[PATCH] D18243: [ASTMatchers] Existing matcher hasAnyArgument fixed

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 23 09:39:08 PDT 2016


alexfh added inline comments.

================
Comment at: docs/ReleaseNotes.rst:123
@@ +122,3 @@
+- hasAnyArgument: Matcher no longer ignores parentheses and implicit casts on
+  the argument before applying the inner matcher. The fix was done allow for
+  greater control by the user. In all existing checkers that use this matcher
----------------
nit: The sentence doesn't parse. Did you mean "The fix allows" or "The fix was done to allow"?

================
Comment at: docs/ReleaseNotes.rst:125
@@ +124,3 @@
+  greater control by the user. In all existing checkers that use this matcher
+  all instances of code hasAnyArgument(<inner matcher>) must be changed to
+  hasAnyArgument(ignoringParenImpCasts(<inner matcher>)).
----------------
nit: Please enclose inline code snippets in double backquotes.


http://reviews.llvm.org/D18243





More information about the cfe-commits mailing list