[PATCH] D17462: Fix a codegen bug for variadic functions with pass_object_size params
Richard Smith via cfe-commits
cfe-commits at lists.llvm.org
Tue Mar 22 15:09:57 PDT 2016
rsmith added inline comments.
================
Comment at: lib/CodeGen/CGCall.cpp:142-143
@@ -132,1 +141,4 @@
+ appendParameterTypes(CGT, prefix, FTP, FD, &SynthesizedParams);
+ RequiredArgs Required =
+ RequiredArgs::forPrototypePlus(FTP, StartParams + SynthesizedParams);
CanQualType resultType = FTP->getReturnType().getUnqualifiedType();
----------------
Would it make sense for `RequiredArgs::forPrototypePlus` to do this computation? Are the other callers of that function also getting the wrong number of required arguments in this case?
http://reviews.llvm.org/D17462
More information about the cfe-commits
mailing list