[PATCH] D18325: export additional header modules from xmmintrin

Richard Smith via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 21 17:49:27 PDT 2016


rsmith added a subscriber: rsmith.

================
Comment at: lib/Headers/module.modulemap:48
@@ -47,3 +47,1 @@
-      export mmx
-      export sse2 // note: for hackish <emmintrin.h> dependency
       header "xmmintrin.h"
----------------
Did you intentionally remove this comment?

================
Comment at: lib/Headers/module.modulemap:55-57
@@ -54,2 +54,5 @@
       header "emmintrin.h"
+      export mm_malloc
+      export mmx
+      export sse
     }
----------------
You shouldn't need to add anything here. sse2 exports sse, which in turn exports mm_malloc and mmx, so users of sse2 get mm_malloc and mmx whether or not sse2 lists them. It's better for it to not do so, as they aren't direct dependencies.


http://reviews.llvm.org/D18325





More information about the cfe-commits mailing list