[PATCH] D18217: [libcxx] Fix -Wdeprecated warnings
Logan Chien via cfe-commits
cfe-commits at lists.llvm.org
Sat Mar 19 08:17:15 PDT 2016
logan added a subscriber: logan.
logan added a comment.
The simple replacement from `throw()` to `_NOEXCEPT` looks fine.
But, why are you adding adding some copy constructors and assignment operators? May you briefly explain the reason?
Besides, I have some concern with the `= default` specifier in some C++98 headers, e.g. `<typeinfo>`. What will happen if the user is compiling with `-std=c++98`?
And, unfortunately, I am not familiar with libc++ code base. I think you will need approvals from @mclow.lists or @EricWF.
http://reviews.llvm.org/D18217
More information about the cfe-commits
mailing list