[PATCH] D15469: Expose cxx constructor and method properties through libclang and python bindings.

Sergey Kalinichev via cfe-commits cfe-commits at lists.llvm.org
Sat Mar 19 04:32:21 PDT 2016


skalinichev added a comment.

I see. There were some changes recently in the indexing functionality. I'm not sure whether this change is intended or not, but since it's not your fault and we already have a lot of tests confirming that clang_CXXMethod_isDeleted is working as expected (e.g. c-index-test -test-print-type) I think it's ok to remove this part of the test then

But just in case please open a bug report about skipped deleted methods with clangIndex.


================
Comment at: tools/libclang/CIndex.cpp:7124
@@ +7123,3 @@
+
+unsigned clang_CXXMethod_isDeleted(CXCursor C) {
+  if (!clang_isDeclaration(C.kind))
----------------
Just occurred to me: what about deleted "not member" functions? Maybe clang_CXXMethod_isDeleted should be renamed to something like clang_Cursor_isDeleted and there we can use FunctionDecl::isDeleted()


http://reviews.llvm.org/D15469





More information about the cfe-commits mailing list