[PATCH] D16965: Fix for Bug 14644 - clang confuses scope operator for global namespace giving extra qualification on member

[Ryan Yee via cfe-commits]

ryee88 added inline comments.

================
Comment at: lib/Sema/SemaDecl.cpp:3803
@@ +3802,3 @@
+    
+    // Per C++ standard [n3485] 3.4.4 Elaborated type specifiers, section 3:
+    // "Cannot introduce an qualified".
----------------
aaron.ballman wrote:
> Can drop the N-paper reference, and replace "3.4.4, section 3" with [basic.lookup.elab]p3
I'm going to re-organize these comments and move the conditional because really all these comments apply too.

================
Comment at: lib/Sema/SemaDecl.cpp:3805
@@ +3804,3 @@
+    // "Cannot introduce an qualified".
+    // A clang::NestedNameSpecifier can represent many kinds of specifiers.
+    // A global-specifier with no nested-name-specifier requires a different
----------------
aaron.ballman wrote:
> Can drop the clang::
ok

================
Comment at: lib/Sema/SemaDecl.cpp:3811
@@ +3810,3 @@
+      ? diag::err_standalone_class_specifier
+      : diagId = diag::err_standalone_class_nested_name_specifier;
+
----------------
aaron.ballman wrote:
> Should remove the diagId = from the else clause.
whoops. will do.


http://reviews.llvm.org/D16965