[PATCH] D17990: [clang-tidy] minor improvements in modernise-deprecated-headers check

[Alexander Kornienko via cfe-commits]

alexfh added inline comments.

================
Comment at: clang-tidy/modernize/DeprecatedHeadersCheck.cpp:59
@@ +58,3 @@
+            {"float.h", "cfloat"},
+            {"inttypes.h", "cinttypes"},
+            {"limits.h", "climits"},
----------------
According to http://www.cplusplus.com/reference/cinttypes/, this header should be changed in C++11 mode only. See also http://llvm.org/PR26982

================
Comment at: clang-tidy/modernize/DeprecatedHeadersCheck.cpp:67
@@ +66,3 @@
+            {"stddef.h", "cstddef"},
+            {"stdint.h", "cstdint"},
+            {"stdio.h", "cstdio"},
----------------
According to http://www.cplusplus.com/reference/cstdint/, this header is a part of C++11 standard, so we should move this to the list below.

================
Comment at: docs/clang-tidy/checks/modernize-deprecated-headers.rst:23
@@ +22,3 @@
+* `<errno.h>` -> `<cerrno>`
+* `<fenv.h>` -> `<cfenv>`         // deprecated since C++11
+* `<float.h>` -> `<cfloat>`
----------------
Is this header actually "deprecated since C++11"?

================
Comment at: docs/clang-tidy/checks/modernize-deprecated-headers.rst:39
@@ +38,3 @@
+* `<string.h>` -> `<cstring>`
+* `<tgmath.h>` -> `<ctgmath>`     // deprecated since C++11
+* `<time.h>` -> `<ctime>`
----------------
Not sure if "deprecated" is the right word here. The wording seems to be slightly different: "This header simply includes <cmath> and <ccomplex>."

================
Comment at: docs/clang-tidy/checks/modernize-deprecated-headers.rst:41
@@ +40,3 @@
+* `<time.h>` -> `<ctime>`
+* `<uchar.h>` -> `<cuchar>`       // deprecated since C++11
+* `<wchar.h>` -> `<cwchar>`
----------------
It's not exactly "deprecated". It has appeared in C++11 and is not particularly useful (just contains a couple of feature macros). Maybe we should just remove #includes of this header as well.


http://reviews.llvm.org/D17990