[PATCH] D18205: [libcxxabi] Disable cxa_thread_atexit_test if unavailable
Jonas Hahnfeld via cfe-commits
cfe-commits at lists.llvm.org
Wed Mar 16 12:24:30 PDT 2016
Hahnfeld added inline comments.
================
Comment at: test/libcxxabi/test/config.py:38
@@ +37,3 @@
+ super(Configuration, self).configure_features()
+ if self.get_lit_bool('thread_atexit', False):
+ self.config.available_features.add('thread_atexit')
----------------
EricWF wrote:
> I would rather default this value to `True`. Would this break in your case?
Not when running all tests from `make` or directly with `llvm-lit` and relative directories. But it would break when starting `llvm-lit` with an absolute path because it then takes the default configuration. I won't ever do that though because I know that this test doesn't work with my version of `glibc` ;-)
Will change and commit tomorrow, thanks!
http://reviews.llvm.org/D18205
More information about the cfe-commits
mailing list