[PATCH] D17104: [VFS] Drop path traversal assertion

Bruno Cardoso Lopes via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 16 09:32:29 PDT 2016


Thanks!

On Wed, Mar 16, 2016 at 5:35 AM, NAKAMURA Takumi <geek4civic at gmail.com> wrote:
> chapuni added a subscriber: chapuni.
> chapuni added a comment.
>
> Excuse me, I have reverted it in r263636.
>
>
> ================
> Comment at: lib/Frontend/ModuleDependencyCollector.cpp:65
> @@ +64,3 @@
> +static bool real_path(StringRef SrcPath, SmallVectorImpl<char> &RealPath) {
> +#ifdef HAVE_REALPATH
> +  char CanonicalPath[256];
> ----------------
> "clang/Config/config.h" doesn't have it and "llvm/Config/config.h" should be unavailable in clang tree.
>
> I suggest you may do;
>
>   # Move it to LLVMSupport.
>   # Detect HAVE_REALPATH in clang's cmakefiles.
>   # Export HAVE_REALPATH into llvm-config.h.
>
>
>
>
> http://reviews.llvm.org/D17104
>
>
>



-- 
Bruno Cardoso Lopes
http://www.brunocardoso.cc


More information about the cfe-commits mailing list