[PATCH] D18123: Fix implicit copy ctor and copy assignment operator warnings when -Wdeprecated passed.
don hinton via cfe-commits
cfe-commits at lists.llvm.org
Mon Mar 14 10:13:30 PDT 2016
hintonda updated this revision to Diff 50611.
hintonda added a comment.
Add move ctor and assignment operator defauls to match
UnresolvedSetImpl's contained SmallVector.
Add FIXME note to LookupResult. Will address FIXME once Marina's
pending change to Sema::LookupInlineAsmField() is available.
http://reviews.llvm.org/D18123
Files:
include/clang/AST/UnresolvedSet.h
include/clang/Sema/Lookup.h
Index: include/clang/Sema/Lookup.h
===================================================================
--- include/clang/Sema/Lookup.h
+++ include/clang/Sema/Lookup.h
@@ -185,6 +185,11 @@
Shadowed(false)
{}
+ // FIXME: Change these to delete once Sema::LookupInlineAsmField is fixed to
+ // not use them.
+ LookupResult(const LookupResult &) = default;
+ LookupResult & operator=(const LookupResult &) = default;
+
~LookupResult() {
if (Diagnose) diagnose();
if (Paths) deletePaths(Paths);
Index: include/clang/AST/UnresolvedSet.h
===================================================================
--- include/clang/AST/UnresolvedSet.h
+++ include/clang/AST/UnresolvedSet.h
@@ -59,8 +59,11 @@
// UnresolvedSet.
private:
template <unsigned N> friend class UnresolvedSet;
- UnresolvedSetImpl() {}
- UnresolvedSetImpl(const UnresolvedSetImpl &) {}
+ UnresolvedSetImpl() = default;
+ UnresolvedSetImpl(const UnresolvedSetImpl &) = default;
+ UnresolvedSetImpl(UnresolvedSetImpl &&) = default;
+ UnresolvedSetImpl& operator=(const UnresolvedSetImpl &) = default;
+ UnresolvedSetImpl& operator=(UnresolvedSetImpl &&) = default;
public:
// We don't currently support assignment through this iterator, so we might
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D18123.50611.patch
Type: text/x-patch
Size: 1256 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160314/77c6122a/attachment.bin>
More information about the cfe-commits
mailing list