[PATCH] D17981: [clang-tidy] Fix clang-tidy to support parsing of assembly statements.

[Etienne Bergeron via cfe-commits]

etienneb added a comment.



> $ du -cksh bin/clang-tidy.exe bin/clang.exe

>  21M     bin/clang-tidy.exe

>  47M     bin/clang.exe

>  68M     total


This is a huge difference. I didn't expect dependencies to bring so much code.
I'm not a fan of having an empty statement and increasing false positives ratio.
Would it be possible to skip whole declarations with asm-stm, and flag them as "ignored / not parsable"?

> Also, should we do this for all Clang tools?


I would prefer a generic solution for every tools. I saw different cases where developers fix this issue differently.

> where the one who builds the binary knows for sure that it won't be used for MS targets


We could gate this code under a define. I'm not a fan of define, but it seems to be a compromise for the size.

Something like: LIBTOOLING_ENABLE_INLINE_ASM_PARSER

If we decide to pursue that direction, then it should probably be for every tools.


http://reviews.llvm.org/D17981