[PATCH] D18136: boost-use-to-string check

[Haojian Wu via cfe-commits]

hokein added a subscriber: hokein.
hokein added a comment.

> Is there any better solution for the basic_string problem?


The current solution looks fine to me. I don't have a better solution. Maybe @alexfh has.


================
Comment at: docs/clang-tidy/checks/boost-use-to-string.rst:6
@@ +5,2 @@
+
+FIXME: Describe what patterns does the check detect and why. Give examples.
----------------
Please update the document.

================
Comment at: test/clang-tidy/boost-use-to-string.cpp:30
@@ +29,3 @@
+  std::string y = boost::lexical_cast<std::string>(xa);
+// CHECK-MESSAGES: :[[@LINE-1]]:19: warning: use std::to_string instead of boost::lexical_cast<std::string> [boost-use-to-string]
+// CHECK-FIXES: std::string y = std::to_string(xa);
----------------
Normally you only need to check the whole warning message in the first line.
For others, use prefix message to keep the line short.


http://reviews.llvm.org/D18136