[PATCH] D18123: Fix implicit copy ctor and copy assignment operator warnings when -Wdeprecated passed.
Marina Yatsina via cfe-commits
cfe-commits at lists.llvm.org
Mon Mar 14 02:09:49 PDT 2016
myatsina added a comment.
In http://reviews.llvm.org/D18123#374170, @hintonda wrote:
> LookupResult's copy ctor and assignment operator are used in Sema::LookupInlineAsmField(). Looks like these were added back in December.
>
> I'll remove the defaults, from this patch, but not sure how to handle LookupInlineAsmField(). Will add author of that change.
>
> OTOH, UnresolvedSetImpl requires an assignment operator since it's a base to UnresolvedSet which has an implicit assignment operator, so I think that change is correct.
I can change my code to avoid the copy ctor and assignment operator of LookupResult - In every iteration I only need to access 2 members of the previous LookupResult (isSingleResult() and getFoundDecl()), I can keep only them instead of the whole object.
Do you want me to upload a patch with this change?
http://reviews.llvm.org/D18123
More information about the cfe-commits
mailing list