r188037 - clang-cl: Support /showIncludes

[Hans Wennborg via cfe-commits]

On Sat, Mar 12, 2016 at 7:50 PM, Nico Weber via cfe-commits
<cfe-commits at lists.llvm.org> wrote:
> On Thu, Aug 8, 2013 at 8:32 PM, Hans Wennborg <hans at hanshq.net> wrote:
>>
>> Author: hans
>> Date: Thu Aug  8 19:32:23 2013
>> New Revision: 188037
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=188037&view=rev
>> Log:
>> clang-cl: Support /showIncludes
>>
>> This option prints information about #included files to stderr. Clang
>> could
>> already do it, this patch just teaches the existing code about the
>> /showIncludes
>> style and adds the flag.
>>
>> Differential Revision: http://llvm-reviews.chandlerc.com/D1333
[..]
>> --- cfe/trunk/test/Frontend/print-header-includes.c (original)
>> +++ cfe/trunk/test/Frontend/print-header-includes.c Thu Aug  8 19:32:23
>> 2013
>> @@ -5,4 +5,11 @@
>>  // CHECK: . {{.*test.h}}
>>  // CHECK: .. {{.*test2.h}}
>>
>> +// RUN: %clang_cc1 -include Inputs/test3.h -E --show-includes -o %t.out
>> %s 2> %t.err
>> +// RUN: FileCheck --check-prefix=MS < %t.err %s
>> +// MS-NOT: test3.h
>
>
> Do you remember why this is a -NOT? From what I can tell, `cl /c empty.cc
> /FItest.h /showIncludes` does print a Note line for test.h. I thought that
> was a bug, but when I wrote a fix I noticed that we have this test that
> explicitly checks that /FI arguments are omitted from /showIncludes output.

I don't remember, but I suspect I just took the non-CL test case,
adopted it to the CL style and didn't notice that they also print for
/FI.

>> +// MS: Note: including file: {{.*test.h}}
>> +// MS: Note: including file:  {{.*test2.h}}
>> +// MS-NOT: Note