[PATCH] D14731: [libcxx] Add clang thread safety annotations to mutex and lock_guard

[Eric Fiselier via cfe-commits]

EricWF added a subscriber: EricWF.
EricWF added a comment.

I tried to do this over the summer. The author of the annotations insisted that it would be a bad idea to apply them to libc++ since it would break existing code. Should these be off by default?

Also at the time the annotations were unstable and somewhat buggy. Has this situtation cleared up?

Also could we add some ".fail.cpp" tests that use Clang verify? I'm happy to give an example if your unfamiliar with how libc++ handles testing.


http://reviews.llvm.org/D14731