[PATCH] D18011: [modules] Diagnose insufficient privileges when trying to load the modulemap

Davide Italiano via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 10 12:21:49 PST 2016


davide added a comment.

Hmm, I think you're right. It's not actually that silent (it fails with a fatal error when trying to load/read).
That said, I think it might still be valuable to emit a diagnostic -- Richard what do you think?

I noticed you reported a very similar problem here: https://llvm.org/bugs/show_bug.cgi?id=20468

Also, I looked at the code more closely and I think the right place to diagnose this would be `lib/Frontend/FrontendAction.cpp`, in `BeginSourceFile`, around line 390, and not where I'm diagnosing it right now. Thoughts?


http://reviews.llvm.org/D18011





More information about the cfe-commits mailing list