Change Request

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 10 10:01:03 PST 2016


On Thu, Mar 10, 2016 at 11:38 AM, Wes Witt via cfe-commits
<cfe-commits at lists.llvm.org> wrote:
> I would like to submit the attached changes for your approval.

Thank you for the patch!

This:

+  let Subjects = SubjectList<[Function, Var, CXXRecord,
ObjCInterface], WarnDiag,
+                             "ExpectedVariableOrFunction">;

should be using ExpectedFunctionVariableOrClass. It's not completely
correct since you're adding Objective-C interfaces, but it's a bit
better than dropping the class part.

Also, patch submissions should include test cases exercising the
differences in the patch, so you should add some tests.

Welcome!

~Aaron


More information about the cfe-commits mailing list