[PATCH] D18024: Remove compile time PreserveName switch based on NDEBUG

[Chandler Carruth via cfe-commits]

chandlerc added inline comments.

================
Comment at: lib/CodeGen/CodeGenAction.cpp:660-663
@@ -660,1 +659,6 @@
+      OwnsVMContext(!_VMContext) {
+#ifdef NDEBUG
+  _VMContext.setDiscardValueNames(true);
+#endif
+}
 
----------------
joker.eph wrote:
> chandlerc wrote:
> > I'm surprised this isn't a driver-side NDEBUG default flip? Can this still be overridden with a flag?
> It's gonna be next patch: plumbing a cc1 flag somehow. Right now this is minimum patch to maintain existing behavior in clang while adapting to the IRBuilder API in LLVM.
Ah, just add a FIXME comment to make it clear that this is a transitional thing and not planned to be the end state?


http://reviews.llvm.org/D18024