[PATCH] D17821: [OpenCL] Complete image types support

Alexey Bader via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 10 08:03:16 PST 2016


bader added a comment.

If there are no objections to adopt this approach I can start working on rebasing that patch to the ToT.


================
Comment at: include/clang/AST/OpenCLImageTypes.def:39
@@ +38,3 @@
+
+IMAGE_READ_TYPE(image1d, OCLImage1d)
+IMAGE_READ_TYPE(image1d_array, OCLImage1dArray)
----------------
Minor comment: any image access qualifier can be applied to any image type, so I think it's better to list all image types once to avoid duplication.



http://reviews.llvm.org/D17821





More information about the cfe-commits mailing list