[PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

[Hal Finkel via cfe-commits]

hfinkel added a comment.

In http://reviews.llvm.org/D17993#370793, @chandlerc wrote:

> If we're not going to fully implement "fdelete-null-pointer-checks" we shouldn't claim to... I'm really worried about us accepting that flag and not actually honoring it.
>
> However, I *do* think this should be guarded by a flag, and it should be specific to the 'this' pointer. And I'm also sufficiently terrified of this that I think the flag should be off to start with so that folks can find out how bad this is really going to be...


I agree with you, but I don't really understand why this particular use of nonnull is scary. Do you really think we have people calling member functions on null pointers on purpose and checking for a null this pointer in their code?


http://reviews.llvm.org/D17993