[PATCH] D17861: [OpenCL] Accept __attribute__((nosvm))

[Aaron Ballman via cfe-commits]

aaron.ballman added inline comments.

================
Comment at: include/clang/Basic/Attr.td:701
@@ -699,1 +700,3 @@
 
+def OpenCLNoSVM : Attr {
+  let Spellings = [GNU<"nosvm">];
----------------
yaxunl wrote:
> aaron.ballman wrote:
> > Since the attribute is ignored by clang, you should inherit from IgnoredAttr.
> I tried that from beginning. If I inherit from IgnoredAttr, it seems to be ignored by the parser and won't reach the sema check part, and I cannot emit error msg based on OpenCL version.
Ah. so it isn't *totally* ignored. Okay, in that case, you should set ASTNode = 0 and SemaHandler = 0.


Repository:
  rL LLVM

http://reviews.llvm.org/D17861