[PATCH] D17764: Add attributes for AMD GPU Tools

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 8 12:13:33 PST 2016


aaron.ballman added inline comments.

================
Comment at: lib/Sema/SemaDeclAttr.cpp:5653
@@ -5655,1 +5652,3 @@
       D->setInvalidDecl();
+    } else if (Attr *A = D->getAttr<AMDGPUToolsInsertNopsAttr>()) {
+      Diag(D->getLocation(), diag::err_attribute_wrong_decl_type)
----------------
All of these should call `D->setInvalidDecl()`, similar to the above kernel attributes.


http://reviews.llvm.org/D17764





More information about the cfe-commits mailing list