[PATCH] D15944: [OpenMP] Parsing and sema support for target update directive
Kelvin Li via cfe-commits
cfe-commits at lists.llvm.org
Mon Mar 7 21:32:41 PST 2016
kkwli0 marked 3 inline comments as done.
================
Comment at: include/clang/AST/OpenMPClause.h:3196
@@ -3195,1 +3195,3 @@
+/// \brief This represents clause 'from' in the '#pragma omp ...'
+/// directives.
----------------
ABataev wrote:
> New clauses must be added in separate patches after commit of the new directive.
Will do
================
Comment at: lib/Parse/ParseOpenMP.cpp:71-74
@@ -69,3 +70,6 @@
!P.getPreprocessor().getSpelling(Tok).compare("point")) ||
- ((i == 1) && !P.getPreprocessor().getSpelling(Tok).compare("data"));
+ ((i == 1) &&
+ !P.getPreprocessor().getSpelling(Tok).compare("data")) ||
+ ((i == 2) &&
+ !P.getPreprocessor().getSpelling(Tok).compare("update"));
} else {
----------------
ABataev wrote:
> Probably, we need to add local enumeric for these constants (0, 1, 2 etc.)
Will use the latest infrastructure.
http://reviews.llvm.org/D15944
More information about the cfe-commits
mailing list