[PATCH] D17908: Add Visual Studio Visualizers for more Clang types

[Aaron Ballman via cfe-commits]

aaron.ballman added a comment.

In http://reviews.llvm.org/D17908#369337, @mspertus wrote:

> Hmm, testing reveals that the preexisting clang.natvis does not work in VS2013!
>
>   Natvis: E:\Users\mspertus\Documents\Visual Studio 2013\Visualizers\clang.natvis(59,21): Error: identifier "clang::TypeAlignmentInBits" is undefined
>   
>
> If I change all clang.natvis occurrences of clang::TypeAlignmentInBits to 4, it now works in VS2013 and VS2015, including all my edits. While this kind of hardwiring is brittle, it seems like the best option until we drop VS2013 support.
>
> Is it ok for me to make that change?


Yeah, I think that change makes sense. We can always rectify it when we drop support for MSVC 2013. Good catch!


http://reviews.llvm.org/D17908