[PATCH] D17762: Fix an assertion failure in setPointOfInstantiation.

[Haojian Wu via cfe-commits]

hokein added a comment.

In http://reviews.llvm.org/D17762#367182, @bkramer wrote:

> This doesn't look right to me. Aborting tree transform on a bad source location seems just wrong. Where is the invalid source location coming from? Also the backtrace seems related to typo correction, maybe the bug is there?


I have post the whole stack trace in PR25668 <https://llvm.org/bugs/show_bug.cgi?id=25668>.
The invalid source location comes from `TypoExpr` which is returned by `ArraySubscriptExpr->getLHS()`, this is also why there is a FIXME in code line <http://clang.llvm.org/doxygen/TreeTransform_8h_source.html#l08352>. After reading the code more throughly, I find that the invalid source location is expected when constructing a `TypoExpr`.

I updated the fixing patch now. We probably don't call `RequireCompleteType` with an invalid source location, which is the same as  trunk at 84793.


http://reviews.llvm.org/D17762