[PATCH] D17910: clang-format: [JS] Handle certain cases of ASI.

Martin Probst via cfe-commits cfe-commits at lists.llvm.org
Sun Mar 6 11:47:42 PST 2016


mprobst added inline comments.

================
Comment at: unittests/Format/FormatTestJS.cpp:56
@@ +55,3 @@
+
+  static void verifyFormatNoMessup(
+      llvm::StringRef Code,
----------------
djasper wrote:
> I don't think it is useful to do this as there are always ways in which formatting can fail leaving the input untouched. We still want to verify that formatting takes place.
> 
> To do so, manually mess up the code in some way and use EXPECT_EQ. There should be various examples in FormatTest.cpp.
Done - introduced a `verifyFormat(str, str, style)` to make it a less verbose.


http://reviews.llvm.org/D17910





More information about the cfe-commits mailing list