r262691 - [MIPS] initFeatureMap() to handle empty string argument

[Eric Christopher via cfe-commits]

I've followed up to the original thread, but I'm fairly certain this isn't
the right patch here.

-eric

On Fri, Mar 4, 2016 at 10:28 AM Eric Christopher <echristo at gmail.com> wrote:

> Test case?
>
> On Fri, Mar 4, 2016, 4:02 AM Bhushan D. Attarde via cfe-commits <
> cfe-commits at lists.llvm.org> wrote:
>
>> Author: bhushan.attarde
>> Date: Fri Mar  4 00:56:29 2016
>> New Revision: 262691
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=262691&view=rev
>> Log:
>> [MIPS] initFeatureMap() to handle empty string argument
>>
>>     SUMMARY:
>>     This patch sets CPU string to its default value when it is not
>> supplied by caller.
>>
>>     Reviewers: vkalintiris, dsanders
>>     Subscribers: mohit.bhakkad, sagar, jaydeep, cfe-commits
>>     Differential Revision: http://reviews.llvm.org/D16139
>>
>> Modified:
>>     cfe/trunk/lib/Basic/Targets.cpp
>>
>> Modified: cfe/trunk/lib/Basic/Targets.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/Targets.cpp?rev=262691&r1=262690&r2=262691&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/lib/Basic/Targets.cpp (original)
>> +++ cfe/trunk/lib/Basic/Targets.cpp Fri Mar  4 00:56:29 2016
>> @@ -6689,6 +6689,8 @@ public:
>>    initFeatureMap(llvm::StringMap<bool> &Features, DiagnosticsEngine
>> &Diags,
>>                   StringRef CPU,
>>                   const std::vector<std::string> &FeaturesVec) const
>> override {
>> +    if (CPU.empty())
>> +      CPU = getCPU();
>>      if (CPU == "octeon")
>>        Features["mips64r2"] = Features["cnmips"] = true;
>>      else
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160304/f11a5ca1/attachment.html>