[PATCH] D17602: [clang-tidy] update links to Google Code Style in docs

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 25 05:53:08 PST 2016


alexfh added inline comments.

================
Comment at: docs/clang-tidy/checks/readability-named-parameter.rst:13
@@ -13,1 +12,3 @@
+https://google.github.io/styleguide/cppguide.html#Function_Declarations_and_
+Definitions
 
----------------
omtcyf0 wrote:
> hokein wrote:
> > This should be in one line?
> It is in html; breakline here is because of 80 chars per line limit.
HTML? This is rst, not html.

Anyway, the link shouldn't be split in two lines, otherwise it won't work. The 80-characters limit is not a hard limit, it can be violated, when you have long links or filenames.

Also, please create diffs with the full context when sending patches for review (http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface).


http://reviews.llvm.org/D17602





More information about the cfe-commits mailing list