[PATCH] D17575: Determine if there's a getDecl member function using less hacks

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 24 13:17:59 PST 2016


On Wed, Feb 24, 2016 at 4:14 PM, Samuel Benzaquen via cfe-commits
<cfe-commits at lists.llvm.org> wrote:
> sbenza added a comment.
>
> I assume you checked that the new trait works on MSVC.

Yes. It's also used in ThreadSafety.cpp, so maybe at some point we may
want to consider generalizing the trait.

> Aren't both the same type of expression SFINAE?

I believe so, yes.

> Is somehow one supported but not the other?

Compiler bugs, most likely. The one I am proposing has the benefit of
working everywhere we care about, at least as far as it's been used in
thread safety analysis for a few releases (so it also works with MSVC
2013 as well as MSVC 2015).

~Aaron


More information about the cfe-commits mailing list