[PATCH] D17558: Add __builtin_canonicalize

Richard Smith via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 23 18:14:45 PST 2016


rsmith added a subscriber: rsmith.
rsmith accepted this revision.
rsmith added a reviewer: rsmith.
rsmith added a comment.
This revision is now accepted and ready to land.

Sure, it makes sense to expose this.


================
Comment at: docs/LanguageExtensions.rst:1743
@@ +1742,3 @@
+
+This provides the semantics of the `LLVM canonicalize intrinsic <http://llvm.org/docs/LangRef.html#llvm-canonicalize-intrinsic>`_.
+
----------------
The cross-reference to the LLVM documentation here is useful, but please lead with a (brief) description of what this builtin does (the first sentence from the LLVM doc would be fine).

================
Comment at: include/clang/Basic/Builtins.def:381-382
@@ +380,4 @@
+// Special FP builtins.
+BUILTIN(__builtin_canonicalize, "dd", "nc")
+BUILTIN(__builtin_canonicalizef, "ff", "nc")
+
----------------
Why is there no `long double` version of this builtin?


http://reviews.llvm.org/D17558





More information about the cfe-commits mailing list