[PATCH] D17484: [clang-tidy] introduce modernize-deprecated-headers check
Alexander Kornienko via cfe-commits
cfe-commits at lists.llvm.org
Tue Feb 23 05:47:04 PST 2016
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good with one nit.
Let me know if you need me to commit the patch for you.
================
Comment at: clang-tidy/modernize/DeprecatedHeadersCheck.cpp:99
@@ +98,3 @@
+ std::string Replacement =
+ (llvm::Twine("<") + llvm::Twine(CStyledHeaderToCxx[FileName]) +
+ llvm::Twine(">"))
----------------
No need to convert all of them to llvm::Twine. The first one is enough to make the compiler choose the right overloaded operators:
(llvm::Twine("<") + CStyledHeaderToCxx[FileName] + ">").str();
http://reviews.llvm.org/D17484
More information about the cfe-commits
mailing list