[PATCH] D17026: Changed ASTImporter DiagnosticsEngine from FromDiag to ToDiag for unsupported ASTNodes Import.
Argyrios Kyrtzidis via cfe-commits
cfe-commits at lists.llvm.org
Sat Feb 20 10:59:09 PST 2016
akyrtzi added a comment.
I'm not sure removing all the Importer.FromDiag() calls is the right thing. You are changing
Importer.FromDiag(D->getLocation(), diag::err_unsupported_ast_node)
to
Importer.ToDiag(SourceLocation(), diag::err_unsupported_ast_node)
and you lose the source location information.
http://reviews.llvm.org/D17026
More information about the cfe-commits
mailing list