[PATCH] D17170: [OPENMP] Codegen for distribute directive

Alexey Bataev via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 19 20:40:00 PST 2016


ABataev added inline comments.

================
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:2126
@@ +2125,3 @@
+  OpenMPSchedType ScheduleNum = getRuntimeSchedule(ScheduleKind, Chunk != nullptr,
+                                                Ordered);
+  auto *UpdatedLocation = emitUpdateLocation(CGF, Loc, OMP_IDENT_KMPC);
----------------
Wrong indentation

================
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:2127
@@ +2126,3 @@
+                                                Ordered);
+  auto *UpdatedLocation = emitUpdateLocation(CGF, Loc, OMP_IDENT_KMPC);
+  auto *ThreadId = getThreadID(CGF, Loc);
----------------
Just 'emitUpdateLocation(CGF, Loc)' please

================
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:2141
@@ +2140,3 @@
+  OpenMPSchedType ScheduleNum = getRuntimeSchedule(SchedKind, Chunk != nullptr);
+  auto *UpdatedLocation = emitUpdateLocation(CGF, Loc, OMP_IDENT_KMPC);
+  auto *ThreadId = getThreadID(CGF, Loc);
----------------
Also, 'emitUpdateLocation(CGF, Loc)'


Repository:
  rL LLVM

http://reviews.llvm.org/D17170





More information about the cfe-commits mailing list