[PATCH] D17360: [cfi] Fix handling of sanitize trap/recover flags in the cross-DSO CFI mode.
Peter Collingbourne via cfe-commits
cfe-commits at lists.llvm.org
Fri Feb 19 11:41:39 PST 2016
pcc added a comment.
What I meant was that it looks like a hack that this is being handled in the driver. The frontend shouldn't care what the value of a trap flag is if a sanitizer is disabled.
Why are we even emitting checks for disabled sanitizers in the target DSO anyway? Can we fail open if the target DSO does not have a particular CFI sanitizer enabled (same as we fail open for non-instrumented DSOs)? That would allow you to remove a little of the complication you added to EmitCheck in http://reviews.llvm.org/D15699.
Repository:
rL LLVM
http://reviews.llvm.org/D17360
More information about the cfe-commits
mailing list