[PATCH] D17456: [libcxx] Reorganize _LIBCPP_LOCALE__L_EXTENSIONS

Jonathan Roelofs via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 19 10:43:35 PST 2016


jroelofs added a comment.

In http://reviews.llvm.org/D17456#357245, @bcraig wrote:

> In http://reviews.llvm.org/D17456#357232, @jroelofs wrote:
>
> > > The private redirector symbol names are all prefixed with _CXX_* so that they won't conflict with user symbols,
> >
> >
> > This is more @mclow.lists/@ericwf's domain, but I think __libcxx_ prefixes would be safer (so that there's no chance of clashing with libstdc++, if they decide to do something similar, or already have).
>
>
> Do we need our headers to coexist with the headers from other C++ implementations?  That seems fraught with peril.  I've tried to do something like that in the past with STLPort in combination with various compilers' STLs, and ADL basically made the results unusable.


I think the headers are a lost cause. It's the symbols I'm actually worried about. There are people who link against both standard libraries (and that's a valid, supported use case).


http://reviews.llvm.org/D17456





More information about the cfe-commits mailing list