[PATCH] D17456: [libcxx] Reorganize _LIBCPP_LOCALE__L_EXTENSIONS
Ben Craig via cfe-commits
cfe-commits at lists.llvm.org
Fri Feb 19 10:14:18 PST 2016
bcraig created this revision.
bcraig added reviewers: scshunt, howard.hinnant, jroelofs, mclow.lists.
bcraig added a subscriber: cfe-commits.
Herald added a subscriber: jfb.
This is one part of many of a locale refactor. See http://reviews.llvm.org/D17146 for an idea of where this is going.
Instead of checking _LIBCPP_LOCALE__L_EXTENSIONS all over, instead check it once, and define the various *_l symbols once. The private redirector symbol names are all prefixed with _CXX_* so that they won't conflict with user symbols, and so they won't conflict with future C library symbols. In particular, glibc likes providing private symbols such as __locale_t, so we should follow a different naming pattern (like _CXX_*) to avoid problems on that front.
Tested on Linux with glibc. Hoping for the best on OSX and the various BSDs.
http://reviews.llvm.org/D17456
Files:
include/__bsd_locale_defaults.h
include/__bsd_locale_fallbacks.h
include/locale
src/locale.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D17456.48509.patch
Type: text/x-patch
Size: 35748 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160219/02f72e73/attachment-0001.bin>
More information about the cfe-commits
mailing list