[PATCH] D17380: [libcxx] Split locale management out of ibm/xlocale.h. NFCI

Craig, Ben via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 19 07:06:53 PST 2016


On 2/19/2016 8:36 AM, Joerg Sonnenberger via cfe-commits wrote:
> On Thu, Feb 18, 2016 at 03:39:29PM +0000, Ben Craig via cfe-commits 
> wrote:
>> Unfortunately, I have no access to an AIX machine to build with, so
>> this change has been made blind.
> Any reason why this is not using "new" and "delete"? I think I would
> prefer to not define uselocale, but that can be left until later.
>
> Joerg
For now, I'm just shuffling functionality around.  The old code used 
calloc and free, so this rearranged code uses calloc and free.

Soon, I will be renaming uselocale to _CXX_uselocale.  On platforms that 
natively have uselocale, _CXX_uselocale will be #define'd to uselocale.  
On platforms like AIX, _CXX_uselocale will be some function.

As for changing calloc and free to new and delete... I'm in favor of 
that, but I'm not the right person to do it.  I'm already nervous enough 
doing mechanical shuffling of code without being able to compile the 
results.

> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a 
Linux Foundation Collaborative Project

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160219/a26a2a62/attachment.html>


More information about the cfe-commits mailing list