[PATCH] D5238: [analyzer] Detect duplicate [super dealloc] calls

[Devin Coughlin via cfe-commits]

dcoughlin updated this revision to Diff 48447.
dcoughlin added a comment.

Addressed additional comments from Anna offline:

- "[super dealloc] called again" is OK as a path note but not good as an error message. I've changed it to "[super dealloc] should not be called multiple times".
- Added a comment about why we need both PreObjCMessage and PostObjCMessage to avoid warning when inling a call to [super dealloc]. (The SubclassCallingSuperDealloc test covers this.)


http://reviews.llvm.org/D5238

Files:
  lib/StaticAnalyzer/Checkers/CMakeLists.txt
  lib/StaticAnalyzer/Checkers/Checkers.td
  lib/StaticAnalyzer/Checkers/ObjCSuperDeallocChecker.cpp
  test/Analysis/DeallocUseAfterFreeErrors.m

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D5238.48447.patch
Type: text/x-patch
Size: 16411 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160219/da1c1a8d/attachment-0001.bin>