[PATCH] D17026: Changed ASTImporter DiagnosticsEngine from FromDiag to ToDiag for unsupported ASTNodes Import.

Argyrios Kyrtzidis via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 18 15:23:56 PST 2016


akyrtzi added a subscriber: akyrtzi.
akyrtzi added a comment.

Doesn't this mean that _all_ of the Importer.FromDiag() calls will be ignored by VerifyDiagnosticConsumer ? Why specifically change only this two and what are we going to do with the others ?
This seems more like needing a fix higher up in the stack, not at the ASTImporter level.


http://reviews.llvm.org/D17026





More information about the cfe-commits mailing list