[PATCH] D17382: [libcxx] Split locale management out of newlib/xlocale.h. NFCI

Ben Craig via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 18 07:57:01 PST 2016


bcraig created this revision.
bcraig added reviewers: jroelofs, mclow.lists.
bcraig added a subscriber: cfe-commits.
Herald added a subscriber: jfb.

This is one part of many of a locale refactor. See http://reviews.llvm.org/D17146 for an idea of where this is going.

For the locale refactor, the locale management functions (newlocale, freelocale, uselocale) are needed in a separate header from the various _l functions. This is because some platforms implement the _l functions in terms of a locale switcher RAII helper, and the locale switcher RAII helper needs the locale management functions. This patch helps pave the way by getting all the functions in the right files, so that later diffs aren't completely horrible.

The "do-nothing" / "nop" locale functions are also useful on their own for other lightweight platforms.  Putting these nop implementations in support/xlocale should enable code sharing.

Unfortunately, I have no access to a newlib system to build and test with, so this change has been made blind. 

http://reviews.llvm.org/D17382

Files:
  include/support/newlib/xlocale.h
  include/support/xlocale/__nop_locale_mgmt.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D17382.48317.patch
Type: text/x-patch
Size: 2955 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160218/4f73737b/attachment.bin>


More information about the cfe-commits mailing list