[PATCH] D17375: Add parentheses around arithmetic in operand of '|' in llvm-dwp.cpp.

Benjamin Kramer via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 18 05:14:23 PST 2016


bkramer added a comment.

I think this is the wrong solution. Per http://www.dwarfstd.org/ShowIssue.php?issue=140421.1

  2.  Calculate a secondary hash H' = (((S >> 32) & MASK(k)) | 1).
  [...]
  4.  Let H = (H + H') modulo M. Repeat at Step 3.

So the OR has to happen before the ADD.


http://reviews.llvm.org/D17375





More information about the cfe-commits mailing list